[FFmpeg-devel] Collection of patches

Benoit Fouet benoit.fouet
Thu Apr 24 14:09:11 CEST 2008


Thorsten Jordan wrote:
> Benoit Fouet schrieb:
>   
>> Thorsten Jordan wrote:
>>     
>>> sorry, my mistake, here is a version with all things fixed, it compiles
>>> also (should have checked before)
>>>
>>> +    /* Pixel aspect ratio setting */
>>> +    if (avctx->sample_aspect_ratio.num < 1 || avctx->sample_aspect_ratio.num > 255 ||
>>> +        avctx->sample_aspect_ratio.den < 1 || avctx->sample_aspect_ratio.den > 255) {
>>> +        av_log(avctx, AV_LOG_ERROR, "Invalid pixel aspect ratio %i/%i\n",
>>> +            avctx->sample_aspect_ratio.num, avctx->sample_aspect_ratio.den);
>>> +            return -1;
>>>   
>>>       
>> weird indentation
>>     
> how would you like it to be? "||" on next line? second line indented
> less than four?
>   

sorry, it wasn't clear enough; I was more talking about:
+            return -1;
that should be:
+        return -1;

-- 
Benoit Fouet
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list