[FFmpeg-devel] [PATCH] Fix crash in libx264 when rc_eq is not set

[Stefano Sabatini]

On date Wednesday 2008-08-27 03:02:36 -0600, Loren Merritt encoded:
> On Tue, 26 Aug 2008, Stefano Sabatini wrote:
> 
> > BTW what will happen when the eval functionality will be removed from
> > libx264? If the psz_rc_eq field will have been removed as well this
> > will break compilation (unless to update the ffmpeg code to comply
> > with latest libx264 versions).
> 
> Yes. If you want to deal with ifdefs, go ahead. But I recommend to remove 
> the line, and thus drop support for rc_eq with old x264 versions too.

Well... I could use the X264_BUILD to do something as

#if X264_BUILD < 61
    if (avctx->rc_eq)
        x4->params.rc.psz_rc_eq = avctx->rc_eq;
#else
        av_log(avctx, AV_LOG_WARNING, "Ignoring the rc_eq set, using the libx264 default one\n");
#endif

the problem with this is that it won't work anyway if the *linked*
library isn't the same of the version of the header. Ideally if were
available a function such as x264_build() then the abovementioned
if/else could be performed run-time, lacking that I believe the best
approach is the simplest and the more robust, so I'm for eliminating
the rc_eq use, but to warn the user about that.

But again, I have no strong opinion on this, what I want mostly is to
fix the crash, so I'll apply what the libx264 maintainer (M?ns?) or
missing its opinion Michael will prefer.

Regards.
-- 
FFmpeg = Freak and Frightening Minimal Proud Elegant Generator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-libx64-rc-eq-crash-03.patch
Type: text/x-diff
Size: 664 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080827/bbe626e3/attachment.patch>