[FFmpeg-devel] [PATCH] fix unused variable warning in faanidct.c

Diego Biurrun diego
Thu Mar 6 01:05:56 CET 2008


On Thu, Mar 06, 2008 at 12:00:05AM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Mar 05, 2008 at 05:18:56PM +0100, Michael Niedermayer wrote:
> >> 
> >> On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego Biurrun wrote:
> >> > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox wrote:
> >> > > $subj
> >> > 
> >> > I have the following in my local tree since yesterday.  Michael, OK to
> >> > commit?
> >> 
> >> without the // and with a unused yes
> >
> > What's so bad about commenting out the variables?
> 
> What purpose does a commented out variable serve?

The same purpose that a block of '#if 0' code serves.  If you enable the
'#if 0' block again, you put the variable back...

Diego




More information about the ffmpeg-devel mailing list