[FFmpeg-devel] [PATCH] fix unused variable warning in faanidct.c

[Michael Niedermayer]

On Thu, Mar 06, 2008 at 01:05:56AM +0100, Diego Biurrun wrote:
> On Thu, Mar 06, 2008 at 12:00:05AM +0000, M?ns Rullg?rd wrote:
> > Diego Biurrun <diego at biurrun.de> writes:
> > 
> > > On Wed, Mar 05, 2008 at 05:18:56PM +0100, Michael Niedermayer wrote:
> > >> 
> > >> On Wed, Mar 05, 2008 at 04:12:26PM +0100, Diego Biurrun wrote:
> > >> > On Wed, Mar 05, 2008 at 10:22:04PM +1100, mark cox wrote:
> > >> > > $subj
> > >> > 
> > >> > I have the following in my local tree since yesterday.  Michael, OK to
> > >> > commit?
> > >> 
> > >> without the // and with a unused yes
> > >
> > > What's so bad about commenting out the variables?
> > 
> > What purpose does a commented out variable serve?
> 
> The same purpose that a block of '#if 0' code serves.  If you enable the
> '#if 0' block again, you put the variable back...

No if you enable the '#if 0' block again, you get a compilation failure, if
the variable has been commented out or removed.

At this point you have to start debuging why it failed ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080306/ac429cc7/attachment.pgp>