[FFmpeg-devel] [PATCH] ARMovie/RPL demuxer rev3

[Michael Niedermayer]

On Fri, Mar 28, 2008 at 01:09:18PM -0700, Eli Friedman wrote:
> On Fri, Mar 28, 2008 at 6:42 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >  > +            // There should always be frames_per_chunk frames in a chunk.
> >  > +            pkt->duration = rpl->frames_per_chunk;
> >
> >  There should be only 1 frame in each AVPacket
> 
> There's no possible way to enforce that correctly for an unknown
> codec; in general, the frame boundaries can be anywhere within the
> chunk.   Like the comment in the patch says, Escape 124 gets
> special-cased, Escape 122 always has rpl->frames_per_chunk == 1, and I
> haven't coded the special-casing for Escape 130. (Taking a look at the
> description, I think the special-casing for Escape 130 is the same as
> for Escape 124, but I can't really test without a working Escape 130
> implementation.).
> 
> What exactly am I supposed to do here?

Print a warning if frames_per_chunk>1 and the code doesnt know how to
split it.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080328/5c61fe1f/attachment.pgp>