[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

[Michael Niedermayer]

On Mon, Nov 03, 2008 at 01:48:59PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Nov 3, 2008 at 12:42 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > what are all thouse variables? i can guess the meaning of prev ;) but
> > what is sn ts and rn?
> >
> > and what is rule that is added?
> 
> rn is rule number, sn is stream number and ts is timestamp.
> 
> Real has streams divided in streams and rules. 

> Streams are types, e.g.
> audio could be 0 while video could be 1.

something isnt correct here, streams are not types, streams have
(codec) types.


> Rules are substreams per
> type, e.g. different bitrates.

and rules are not substreams, i mean this in a semantical and english sense
not disputing that this is what the variables with these names are.


> You can request and receive multiple,
> which are thus separated by stream and rule number. Ever packet also
> has a timestamp. We use this for (all 3) for discovering whether is is
> a keyframe (if the streamnumber & 1 == 0, then it is a keyframe) and
> finding out which AVStream the packet belongs to.

"streamnumber & 1 == 0, then it is a keyframe" as well contradicts the
meaning of streamnumber

i think you should name variables so their names correspond to what they
represent.
the names
stream_num, stream_set_num, stream_num_in_set could be an option, possibly
there are better ones ...


> 
> > (yes iam asking silly questions but by clarifying these it might become
> >  easier to review the code for me or others without having to spend time
> >  figuring out what everything is, also the code should become more readable
> 
> I can add doxy comments if wanted.

comments are good, self explanatory code is better

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Thouse who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081109/91fdf683/attachment.pgp>