[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

[Ronald S. Bultje]

Hi,

On Sun, Nov 9, 2008 at 8:03 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> Streams are types, e.g.
>> audio could be 0 while video could be 1.
>
> something isnt correct here, streams are not types, streams have
> (codec) types.
>
>> Rules are substreams per
>> type, e.g. different bitrates.
>
> and rules are not substreams, i mean this in a semantical and english sense
> not disputing that this is what the variables with these names are.

OK, I renamed to sub_strm and set_nr, is that OK?

>> You can request and receive multiple,
>> which are thus separated by stream and rule number. Ever packet also
>> has a timestamp. We use this for (all 3) for discovering whether is is
>> a keyframe (if the streamnumber & 1 == 0, then it is a keyframe) and
>> finding out which AVStream the packet belongs to.
>
> "streamnumber & 1 == 0, then it is a keyframe" as well contradicts the
> meaning of streamnumber
[..]

I added a comment to that statement that set_nr & 1 is a
(non-)keyframe flag. Not really best, but otherwise I have to make it
an actual variable which is silly.

New patch attached, hopefully this addresses your concerns.

Ronald