[FFmpeg-devel] [PATCH][RFC] nsv seeking

[Jai Menon]

On 4/15/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Tue, Apr 14, 2009 at 10:22:56PM +0530, Jai Menon wrote:
>  > On 3/20/09, Michael Niedermayer <michaelni at gmx.at> wrote:
>  > > On Mon, Mar 16, 2009 at 12:15:27PM +0530, Jai Menon wrote:

[...]

>  > @@ -453,6 +465,16 @@ static int nsv_parse_NSVs_header(AVFormatContext *s, AVFormatParameters *ap)
>
> >              av_set_pts_info(st, 64, framerate.den, framerate.num);
>  >              st->start_time = 0;
>  >              st->duration = av_rescale(nsv->duration, framerate.num, 1000*framerate.den);
>  > +
>  > +            for(i=0;i<nsv->index_entries;i++) {
>  > +                if(nsv->extended_index_data) {
>  > +                    av_add_index_entry(st, nsv->nsvf_index_data[i], nsv->extended_index_data[i],
>
>
> i think nsvf_index_data and extended_index_data are poor names

Any suggestions? I could send a separate patch for nsvf_index_data.
I named it extended_index_data because this is what the spec calls it.

>  nsvf is in a nsv file demuxer redundant
>  index_data is a little generic, is it time? file position?  ...

index_data is the file offset.

> > +        if(nsv->extended_index_data) {
>
> > +            av_freep(&nsv->extended_index_data);
>  > +        }
>
>  the if() is redundant

Changed locally.

-- 
Regards,

Jai