[FFmpeg-devel] [PATCH][RFC] nsv seeking

[Michael Niedermayer]

On Wed, Apr 15, 2009 at 10:03:22AM +0530, Jai Menon wrote:
> On 4/15/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Tue, Apr 14, 2009 at 10:22:56PM +0530, Jai Menon wrote:
> >  > On 3/20/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> >  > > On Mon, Mar 16, 2009 at 12:15:27PM +0530, Jai Menon wrote:
> 
> [...]
> 
> >  > @@ -453,6 +465,16 @@ static int nsv_parse_NSVs_header(AVFormatContext *s, AVFormatParameters *ap)
> >
> > >              av_set_pts_info(st, 64, framerate.den, framerate.num);
> >  >              st->start_time = 0;
> >  >              st->duration = av_rescale(nsv->duration, framerate.num, 1000*framerate.den);
> >  > +
> >  > +            for(i=0;i<nsv->index_entries;i++) {
> >  > +                if(nsv->extended_index_data) {
> >  > +                    av_add_index_entry(st, nsv->nsvf_index_data[i], nsv->extended_index_data[i],
> >
> >
> > i think nsvf_index_data and extended_index_data are poor names
> 
> Any suggestions? I could send a separate patch for nsvf_index_data.
> I named it extended_index_data because this is what the spec calls it.

what does it contain?


> 
> >  nsvf is in a nsv file demuxer redundant
> >  index_data is a little generic, is it time? file position?  ...
> 
> index_data is the file offset.

so file offset should be in the name

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090415/a82c1a54/attachment.pgp>