[FFmpeg-devel] [PATCH] RTSP-MS 15/15: move packet_time_start zero value assignment in asf.c

Ronald S. Bultje rsbultje
Thu Apr 16 16:53:50 CEST 2009


Hi,

On Thu, Apr 16, 2009 at 10:30 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Apr 16, 2009 at 10:14:59AM -0400, Ronald S. Bultje wrote:
[..]
>> Returning EIO, which causes a return of EIO to ffplay. Ffplay then
>> checks for EOF, isn't there, reruns and we re-enter this loop. We
>> never read a single byte, we just skip.
>
> If asf finds an inconsistancy it should try to resync not return EIO

I guess that makes sense... What do you think of the attached? That
piece of code looks very silly to me anyway.

Ronald
-------------- next part --------------
Index: ffmpeg-svn/libavformat/asfdec.c
===================================================================
--- ffmpeg-svn.orig/libavformat/asfdec.c	2009-04-15 20:40:08.000000000 -0400
+++ ffmpeg-svn/libavformat/asfdec.c	2009-04-16 10:52:30.000000000 -0400
@@ -712,10 +712,6 @@
             /* fail safe */
             url_fskip(pb, ret);
 
-            asf->packet_pos= url_ftell(pb);
-            if (asf->data_object_size != (uint64_t)-1 &&
-                (asf->packet_pos - asf->data_object_offset >= asf->data_object_size))
-                return AVERROR(EIO); /* Do not exceed the size of the data object */
             return 1;
         }
         if (asf->packet_time_start == 0) {



More information about the ffmpeg-devel mailing list