[FFmpeg-devel] [PATCH] RTSP-MS 15/15: move packet_time_start zero value assignment in asf.c

[Michael Niedermayer]

On Thu, Apr 16, 2009 at 10:53:50AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Thu, Apr 16, 2009 at 10:30 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Apr 16, 2009 at 10:14:59AM -0400, Ronald S. Bultje wrote:
> [..]
> >> Returning EIO, which causes a return of EIO to ffplay. Ffplay then
> >> checks for EOF, isn't there, reruns and we re-enter this loop. We
> >> never read a single byte, we just skip.
> >
> > If asf finds an inconsistancy it should try to resync not return EIO
> 
> I guess that makes sense... What do you think of the attached? That
> piece of code looks very silly to me anyway.

have you tested it beyond compilation?

The check you remove IS the EOF check it just returns EIO as it was
written prior to EOF being used
now maybe the check is unneeded and we can remove it and the variables
it uses can be removed as well, if so iam in favor of course.
But it does not appear you know what check you removed or what effect
that has

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090416/a4468473/attachment.pgp>