[FFmpeg-devel] [PATCH] Fix for broken build

[Aurelien Jacobs]

On Sat, 24 Jan 2009 14:09:48 -0800
Art Clarke <aclarke at xuggle.com> wrote:

> On Sat, Jan 24, 2009 at 2:04 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > Hi,
> >
> > On Sat, Jan 24, 2009 at 4:50 PM, Art Clarke <aclarke at xuggle.com> wrote:
> >> On Sat, Jan 24, 2009 at 11:39 AM, Art Clarke <aclarke at xuggle.com> wrote:
> >>> 2) change the configure script to install config.h by default (a bad
> >>> idea I think, but I'm not sure).
> >> and no I know why a bad idea; because other (admittedly stupid)
> >> programs might install a /usr/local/config.h and either override
> >> libav's, or ffmpeg would override someone elses.
> >
> > It's also a packaging problem. The build and install/run host might
> > not be the same, and thus their config.h might (have to) differ.
> 
> Agreed.  So that leaves two proposed solutions:
> 1) the patch I added which removes the unneeded include of config.h in mem.h

For this to be acceptable you also need to remove the following code:

#elif HAVE_INLINE_ASM
    #error The asm code needs alignment, ...

because that's what actually require config.h.
If removing this code is not acceptable, the only alternative seems
to be to move the whole DECLARE_ALIGNED() and DECLARE_ASM_CONST()
to a non-installed header.

> 2) tell libav users they can't include mem.h, and hence cannot use
> av_malloc or av_free

This is obviously not acceptable.

Aurel