[FFmpeg-devel] [PATCH] Fix for broken build

[Art Clarke]

On Sat, Jan 24, 2009 at 3:29 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> On Sat, 24 Jan 2009 14:09:48 -0800
> Art Clarke <aclarke at xuggle.com> wrote:
>> 1) the patch I added which removes the unneeded include of config.h in mem.h
>
> For this to be acceptable you also need to remove the following code:
>
> #elif HAVE_INLINE_ASM
>    #error The asm code needs alignment, ...
>
> because that's what actually require config.h.

All my patch did was revert to the old (and yes potentially buggy
code).  My thinking was it was better to revert the file for existing
users.  My hope was that Diego or someone else would back out their
change and have a rethink and try it again in a way that doesn't break
existing users.

I am not an expert in mem.h, and therefore I think it would be
dangerous to have me rooting around trying to fix all the #if
statements.  Really, I'm just suggesting we reinstate the old behavior
that mostly worked for users instead of the new code which breaks any
libav user of av_malloc().

> If removing this code is not acceptable, the only alternative seems
> to be to move the whole DECLARE_ALIGNED() and DECLARE_ASM_CONST()
> to a non-installed header.
See comment above.

>
>> 2) tell libav users they can't include mem.h, and hence cannot use
>> av_malloc or av_free
>
> This is obviously not acceptable.
On this we wholeheartedly agree; I was just trying to find a way to
solve a problem for any user of libav, and wanted to be thorough in
the options I presented.

- Art

-- 
http://www.xuggle.com/
xu?ggle (z?' gl) v. To freely encode, decode, and experience audio and video.

Use Xuggle to get the power of FFMPEG in Java.