[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Diego Biurrun]

On Mon, Mar 02, 2009 at 03:18:51PM +0100, Olivier Guilyardi wrote:
> 
> --- libavdevice/jack_audio.c	(revision 0)
> +++ libavdevice/jack_audio.c	(revision 0)
> @@ -0,0 +1,295 @@
> --- libavformat/Makefile	(revision 17730)
> +++ libavformat/Makefile	(working copy)
> @@ -5,7 +5,7 @@
>  
> -OBJS = allformats.o cutils.o metadata.o metadata_compat.o options.o os_support.o sdp.o utils.o
> +OBJS = allformats.o cutils.o metadata.o metadata_compat.o options.o os_support.o sdp.o utils.o timefilter.o

alphabetical order

> --- libavformat/timefilter.c	(revision 0)
> +++ libavformat/timefilter.c	(revision 0)
> @@ -0,0 +1,131 @@
> +
> +TimeFilter *
> +ff_timefilter_new(double period, double bandwidth)

We usually have this on one line.

> Index: libavformat/timefilter.d
> ===================================================================
> --- libavformat/timefilter.d	(revision 0)
> +++ libavformat/timefilter.d	(revision 0)
> @@ -0,0 +1 @@
> +libavformat/timefilter.o: libavformat/timefilter.c libavformat/timefilter.h

This should not be part of the patch.

> --- libavformat/timefilter.h	(revision 0)
> +++ libavformat/timefilter.h	(revision 0)
> @@ -0,0 +1,130 @@
> +
> +#ifndef AVFORMAT_TIMEFILTER_H
> +#define AVFORMAT_TIMEFILTER_H
> +
> +void      ff_timefilter_update(TimeFilter *self, double system_time);

weird amount of spaces

Does this header pass 'make checkheaders'?

> +#endif
> +
> +
> +
> +
> +
> +

Please add an #endif comment and avoid those empty lines.

> Index: libavformat/timefilter.o
> ===================================================================
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> 
> Property changes on: libavformat/timefilter.o
> ___________________________________________________________________
> Added: svn:mime-type
>    + application/octet-stream

This is also bogus.

Diego