[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Olivier Guilyardi]

Attached: timefilter libavformat patch version 0.2

Diego Biurrun wrote:
> On Mon, Mar 02, 2009 at 03:18:51PM +0100, Olivier Guilyardi wrote:
>> --- libavdevice/jack_audio.c	(revision 0)
>> +++ libavdevice/jack_audio.c	(revision 0)
>> @@ -0,0 +1,295 @@
>> --- libavformat/Makefile	(revision 17730)
>> +++ libavformat/Makefile	(working copy)
>> @@ -5,7 +5,7 @@
>>  
>> -OBJS = allformats.o cutils.o metadata.o metadata_compat.o options.o os_support.o sdp.o utils.o
>> +OBJS = allformats.o cutils.o metadata.o metadata_compat.o options.o os_support.o sdp.o utils.o timefilter.o
> 
> alphabetical order

ordered

> 
>> --- libavformat/timefilter.c	(revision 0)
>> +++ libavformat/timefilter.c	(revision 0)
>> @@ -0,0 +1,131 @@
>> +
>> +TimeFilter *
>> +ff_timefilter_new(double period, double bandwidth)
> 
> We usually have this on one line.

corrected

> 
>> Index: libavformat/timefilter.d
>> ===================================================================
>> --- libavformat/timefilter.d	(revision 0)
>> +++ libavformat/timefilter.d	(revision 0)
>> @@ -0,0 +1 @@
>> +libavformat/timefilter.o: libavformat/timefilter.c libavformat/timefilter.h
> 
> This should not be part of the patch.

wiped out (caused by bogus svn add libavformat/timefilter.*)

> 
>> --- libavformat/timefilter.h	(revision 0)
>> +++ libavformat/timefilter.h	(revision 0)
>> @@ -0,0 +1,130 @@
>> +
>> +#ifndef AVFORMAT_TIMEFILTER_H
>> +#define AVFORMAT_TIMEFILTER_H
>> +
>> +void      ff_timefilter_update(TimeFilter *self, double system_time);
> 
> weird amount of spaces

fixed

> 
> Does this header pass 'make checkheaders'?

now it does

> 
>> +#endif
>> +
>> +
>> +
>> +
>> +
>> +
> 
> Please add an #endif comment and avoid those empty lines.

fixed

> 
>> Index: libavformat/timefilter.o
>> ===================================================================
>> Cannot display: file marked as a binary type.
>> svn:mime-type = application/octet-stream
>>
>> Property changes on: libavformat/timefilter.o
>> ___________________________________________________________________
>> Added: svn:mime-type
>>    + application/octet-stream
> 
> This is also bogus.

removed

--
  Olivier

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-r17736-timefilter-0.2.patch
Type: text/x-patch
Size: 9029 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090302/4ca65b28/attachment.bin>