[FFmpeg-devel] [PATCH] Implement av_find_pix_fmt_descriptor* functions

[Stefano Sabatini]

On date Sunday 2009-03-22 02:13:58 +0100, Michael Niedermayer encoded:
> On Sun, Mar 22, 2009 at 01:47:17AM +0100, Stefano Sabatini wrote:
> > Hi all.
> > 
> > I'm not sure if is better:
> > av_find_pix_fmt_descriptor()
> > av_find_pix_fmt_descriptor_by_name()
> > 
> > which is similar to:
> > avcodec_find_decoder()
> > avcodec_find_decoder_by_name()
> > 
> > or
> > av_get_pix_fmt_descriptor()
> > av_get_pix_fmt_descriptor_by_name()
> > 
> > which is more similar to:
> > avcodec_get_pix_fmt()
> > 
> > I think "get" is more appropriate for the first case
> > (av_get_pix_fmt_descriptor) since we don't have to execute a search
> > but just pickup the pixdesc from the internal array, while "find"
> > looks more appropriate in the second case.
> > 
> > Anyway I don't have a strong opinion, so I'd like to hear your
> > opinion.
> > 
> > As for the little test I'll drop it when committing.
> 
> what is the point in wraper functions around
> array[x]
> ?

* the pix_fmt_desc array is not public

* I think they're convenient anyway, even if we decide to make
  pix_fmt_desc public, but I agree in that case maybe is not a good
  idea to complicate the API for little gain.

Regards.
-- 
FFmpeg = Fostering Foolish Martial Patchable ExchanGer