[FFmpeg-devel] [PATCH] Implement av_find_pix_fmt_descriptor* functions

[Michael Niedermayer]

On Sun, Mar 22, 2009 at 09:19:43AM +0100, Stefano Sabatini wrote:
> On date Sunday 2009-03-22 02:13:58 +0100, Michael Niedermayer encoded:
> > On Sun, Mar 22, 2009 at 01:47:17AM +0100, Stefano Sabatini wrote:
> > > Hi all.
> > > 
> > > I'm not sure if is better:
> > > av_find_pix_fmt_descriptor()
> > > av_find_pix_fmt_descriptor_by_name()
> > > 
> > > which is similar to:
> > > avcodec_find_decoder()
> > > avcodec_find_decoder_by_name()
> > > 
> > > or
> > > av_get_pix_fmt_descriptor()
> > > av_get_pix_fmt_descriptor_by_name()
> > > 
> > > which is more similar to:
> > > avcodec_get_pix_fmt()
> > > 
> > > I think "get" is more appropriate for the first case
> > > (av_get_pix_fmt_descriptor) since we don't have to execute a search
> > > but just pickup the pixdesc from the internal array, while "find"
> > > looks more appropriate in the second case.
> > > 
> > > Anyway I don't have a strong opinion, so I'd like to hear your
> > > opinion.
> > > 
> > > As for the little test I'll drop it when committing.
> > 
> > what is the point in wraper functions around
> > array[x]
> > ?
> 
> * the pix_fmt_desc array is not public

having the descriptors public but not the array makes no sense
having neither public makes your function useless


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090322/75e19091/attachment.pgp>