[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 9) (ping)

[Diego Biurrun]

On Mon, May 18, 2009 at 02:11:02PM +0200, Cyril Russo wrote:
> 
> Ping for previous mail. I've made the correction asked by Michael in the 
> attached patch. Please review.

Build system part OK.

> --- libavcodec/vaapi_h264.c	(r??vision 0)
> +++ libavcodec/vaapi_h264.c	(r??vision 0)
> @@ -0,0 +1,316 @@
> +
> +/** Reconstruct bitstream slice_type */

Please end complete sentences in periods, same below.

> +static void vaapi_h264_fill_vaapi_picture(VAPictureH264 *va_pic, Picture *pic, int pic_structure)

extra good karma for breaking overly long lines, more below

> +    for (list = 0; list < h->list_count; list++) {
> +        for (i = 0; i < h->ref_count[list]; i++) {
> +            Picture * const pic = &h->ref_list[list][i];
> +            if (pic->reference) {
> +                if (dpb_add(&dpb, pic) < 0)
> +                    return -1;
> +            }
> +        }
> +    }

some unnecessary {}

Diego