[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 9) (ping)

[Michael Niedermayer]

On Mon, May 18, 2009 at 02:11:02PM +0200, Cyril Russo wrote:
> Hi,
>
> Ping for previous mail. I've made the correction asked by Michael in the 
> attached patch. Please review.

[...]
> +/** Translate an FFmpeg Picture into its VA API form */
> +static void vaapi_h264_fill_vaapi_picture(VAPictureH264 *va_pic, Picture *pic, int pic_structure)

Missing documentation for the function parameters

[...]
> +/** Initialize reference picture lists (7.4.3.1) */
> +static void vaapi_h264_fill_RefPicList(VAPictureH264 RefPicList[32], Picture *ref_list, unsigned int ref_count)

7.4.3.1 ?
from h264 ? from vaapi?

and if its h264, what is that supposed to mean? the file is a interface
between vaapi and our h264 decoder.


[...]
> +static int vaapi_h264_start_frame(AVCodecContext *avctx, av_unused const uint8_t *buffer, av_unused uint32_t size)

i would prefer all vaapi prefixes to be
removed from function names that are part of libav*, such prefix should
be reserved for vaapi

PS: also any other kind of cleanup you can think of is likely welcome


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090519/4eaa32d3/attachment.pgp>