[FFmpeg-devel] [PATCH] Add VorbisComment writing to ogg-vorbis files (bump)

[Daniel Verkamp]

On Sun, Apr 18, 2010 at 5:47 AM, James Darnley <james.darnley at gmail.com> wrote:
> On 8 April 2010 15:39, James Darnley <james.darnley at gmail.com> wrote:
>> On 31 March 2010 00:35, James Darnley <james.darnley at gmail.com> wrote:
>>>>As the subject says, the attached patch adds VorbisComment writing to ogg-vorbis files.
>>>
>>> Perhaps more explaination will garner some attention.
>>>
>>> The change to ogg_write_vorbiscomment() is because vorbis requires
>>> VorbisComments to have the framing bit whereas flac and speex (based
>>> on inspection of a file made by speexenc) do not.
>>>
>>> Any other comments about the way I've done stuff?
>>>
>>
>> New patch attached. ?Changed due to the recent AVERROR() changes. ?A
>> couple of minor cosmetic changes too.
>>
>
> bump... ?does nobody want this?

This looks good to me at first glance and works for at least a simple
-map_meta_data from an existing file with tags, but I'm not ogg
maintainer...

Thanks,
-- Daniel Verkamp