[FFmpeg-devel] [PATCH 6/6] Implement v4l2 input size autodetection.

Stefano Sabatini stefano.sabatini-lala
Tue Apr 27 00:27:15 CEST 2010


On date Monday 2010-04-26 00:09:55 +0200, Luca Abeni encoded:
> On Sun, 2010-04-25 at 23:07 +0200, Stefano Sabatini wrote:
> [...]
> > > > +    if (!ap->width && !ap->height) {
> > > 
> > > This should be "||"
> > 
> > Not sure about what we should consider as "unspecified", I assume this
> > only corresponds to the case 0x0, it seems to me that if at least one
> > value is set to != 0 then the size should not be considered
> > unspecified
> 
> Not sure what's the point is specifying "320x0" as a size...
> 
> Anyway, if you prefer "&&" for some reason, then feel free to commit.

Thanks, applied.

BTW, I'm noticing that:
ffplay -f video4linux2 /dev/video0

starts with a smooth playback, then the framerate seems to linearly
decrease and becomes very slow just after few seconds.

I'll try to inspect the issue, in the meaningwhile can someone have a
look at it and conferm that the issue is reproducible (assuming the
problem is in ffplay/v4l2.c)?

v4l2 playback works fine here at least with cheese (both mplayer and
vlc failed for a reason or another), and I remember the same device
worked fine with v4l and ffplay at the times of Debian Lenny.

Regards.
-- 
FFmpeg = Friendly Fabulous Minimalistic Pitiful Eager God



More information about the ffmpeg-devel mailing list