[FFmpeg-devel] [PATCH 6/6] Implement v4l2 input size autodetection.

[Luca Abeni]

Stefano Sabatini wrote:
> On date Monday 2010-04-26 00:09:55 +0200, Luca Abeni encoded:
>> On Sun, 2010-04-25 at 23:07 +0200, Stefano Sabatini wrote:
>> [...]
>>>>> +    if (!ap->width && !ap->height) {
>>>> This should be "||"
>>> Not sure about what we should consider as "unspecified", I assume this
>>> only corresponds to the case 0x0, it seems to me that if at least one
>>> value is set to != 0 then the size should not be considered
>>> unspecified
>> Not sure what's the point is specifying "320x0" as a size...
>>
>> Anyway, if you prefer "&&" for some reason, then feel free to commit.
> 
> Thanks, applied.
> 
> BTW, I'm noticing that:
> ffplay -f video4linux2 /dev/video0

I never used ffplay with vide4linux2; I always use ffmpeg or my own
libav-based program, and they work fine... Which kind of video device
are you using? Is the frame rate correctly detected? Does it change
anything if you explicitly specify the frame rate?



				Luca