[FFmpeg-devel] [PATCH] Indeo 5 decoder

[Reimar Döffinger]

On Mon, Feb 01, 2010 at 07:49:55PM +0200, Kostya wrote:
> +    uint32_t        frame_num;

Only a 8-bit value is stored in that, also it is unused...

> +    uint16_t        check_sum;       ///< frame checksum

drop the _, it makes it sound like a flag.

> +    uint16_t        gop_hdr_size;

Unused?

> +    int32_t         gop_num;         ///< gop number

Seems unused as well.

> +    /* get band checksum if present */
> +    if (get_bits1(&ctx->gb)) {
> +        band->checksum = get_bits(&ctx->gb, 16);
> +        band->checksum_present = 1;
> +    } else {
> +        band->checksum_present = 0;
> +    }

band->checksum_present = get_bits1(&ctx->gb);
if (band->checksum_present)
    band->checksum = get_bits(&ctx->gb, 16);

The comment also seems a bit pointless to me, is there any chance it
could be unclear what the code does?