[FFmpeg-devel] [PATCH] Indeo 5 decoder

[Kostya]

On Wed, Feb 03, 2010 at 09:27:29PM +0100, Reimar D?ffinger wrote:
> On Mon, Feb 01, 2010 at 07:49:55PM +0200, Kostya wrote:
> > +    uint32_t        frame_num;
> 
> Only a 8-bit value is stored in that, also it is unused...

still, it's in the bitstream. I'd like to keep it for debug purposes. 

> > +    uint16_t        check_sum;       ///< frame checksum
> 
> drop the _, it makes it sound like a flag.

done
 
> > +    uint16_t        gop_hdr_size;
> 
> Unused?

same as with frame_num

> > +    int32_t         gop_num;         ///< gop number
> 
> Seems unused as well.

indeed, dropped

> > +    /* get band checksum if present */
> > +    if (get_bits1(&ctx->gb)) {
> > +        band->checksum = get_bits(&ctx->gb, 16);
> > +        band->checksum_present = 1;
> > +    } else {
> > +        band->checksum_present = 0;
> > +    }
> 
> band->checksum_present = get_bits1(&ctx->gb);
> if (band->checksum_present)
>     band->checksum = get_bits(&ctx->gb, 16);

changed

> The comment also seems a bit pointless to me, is there any chance it
> could be unclear what the code does?

Why don't you believe in unlimited people stupidity?
I've got rid of most obvious comments though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indeo5.patch
Type: text/x-diff
Size: 43277 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100204/6e97a00a/attachment.patch>