[FFmpeg-devel] [PATCH] urlconcat protocol

[Michael Niedermayer]

On Sat, Feb 06, 2010 at 07:57:06AM +0100, Michele Orr? wrote:
> fixed.
> 
> > +    char *urinod = NULL, *tmpunod;
> >
> > in general is a good idea to define
> > variables only in the block where they're used.
> >
> ISO C90 forbids mixed declarations and code.

its ok to put declarations at the begin of blocks (that is after {) like
if(blah){
    int i;
    ...
}

whats not ok in older C specs is

func(123);  <-- statement
int i;      <-- declaration



>  Makefile     |    1 
>  allformats.c |    1 
>  concat.c     |  192 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 194 insertions(+)
> fa43fa0d06739c5c3570178a1daaa6507444993b  uconcatp.patch

if its tested and works, then ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100206/7b80067a/attachment.pgp>