[FFmpeg-devel] [PATCH][0.5] libx264.c backport

[Reinhard Tartler]

On Mo, Feb 15, 2010 at 09:59:01 (CET), Jason Garrett-Glaser wrote:

> On Mon, Feb 15, 2010 at 12:02 AM, Reinhard Tartler <siretart at tauware.de> wrote:
>> Hi,
>>
>> Find attached a propsed patch to backport libavcodec/libx264.c.
>>
>> Features:
>>
>> ?- supposed to work with x264 API versions from 65 to 84
>> ?- tested with API version 67 (built statically), encoding works fine
>> ?- tested with API version 84 (built dynamically in form of a debian
>> ? package), encoding works fine
>> ?- work is heavily based on work by Jason
>> ?- the "patch" is actually based on the libx264.c version currently in
>> ? trunk. It is nevertheless presented in form of a diff against
>> ? branches/0.5. When reviewing, please make sure to diff against trunk
>> ?- some (most?) presets have been updated
>>
>> Left questions:
>>
>> ?- do we want to have this backport in branches/0.5 at all? (I think so)
>> ?- how does this updated libx264 wrapper work with the updated presets
>> ? but compiled against API version 65/67?
>
> Some notes about this:
>
> 1) It should work just fine with older x264 APIs
>
> 2) I explicitly designed the patch to support all x264 APIs between 65
> and today, with a minimum of ifdefs.  Note I did _not_ design the
> patch to require the minimum amount of _changes_ from 0.5.  As I don't
> care at all about 0.5, let alone its svn history, my goal was to make
> the best code possible, not the best patch.

[ sidenote, by proposing this patch, you already demonstrated that you
  do care about the 0.5 branch ]

Diego suggested to backport r20083 from trunk in order to make the patch
cleaner. Find an updated patch attached.

With Jasons explanation about the ffpresets on IRC (basically the new
presets won't work with an ffmpeg without that backport, but we can
expect people that deploy the backported libavcodec to also update the
presets), and my tests so far, I'm very much inclined to do that change
for the ubuntu package and for the 0.5 branch.

Diego (or other ppl interested), what do you think about this patch?
To me, this is the last scheduled change I'm aware of for 0.5.1. I
think we should be able to release 0.5.1 this weekend. After that, I
think we can continue on planing/working on 0.6.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: libx264-backport-2.patch
Type: text/x-diff
Size: 18266 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100215/1ad35f3f/attachment.patch>
-------------- next part --------------

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4