[FFmpeg-devel] [PATCH] Bink Video decoder for FFmpeg 0.6

[Jason Garrett-Glaser]

>> + ? ? ? ?if (!plane || !c->swap_planes)
>> + ? ? ? ? ? ?plane_idx = plane;
>> + ? ? ? ?else
>> + ? ? ? ? ? ?plane_idx = plane ^ 3;
>>
>> I'd ternary this.
>
> Why?

Cleaner, shorter.

> Mainly because quant table index must be read after all DCT coefficients
> are decoded (sounds like bad design to me).

Sounds like you need a dequant DSP function then.  This would benefit
greatly from asm.

You could also track the last nnz and only dequant up to it.

Dark Shikari