[FFmpeg-devel] [PATCH] Bink Video decoder for FFmpeg 0.6

[Kostya]

On Wed, Feb 17, 2010 at 06:07:37AM -0800, Jason Garrett-Glaser wrote:
> >> + ? ? ? ?if (!plane || !c->swap_planes)
> >> + ? ? ? ? ? ?plane_idx = plane;
> >> + ? ? ? ?else
> >> + ? ? ? ? ? ?plane_idx = plane ^ 3;
> >>
> >> I'd ternary this.
> >
> > Why?
> 
> Cleaner, shorter.

ok
 
> > Mainly because quant table index must be read after all DCT coefficients
> > are decoded (sounds like bad design to me).
> 
> Sounds like you need a dequant DSP function then.  This would benefit
> greatly from asm.
> 
> You could also track the last nnz and only dequant up to it.

I've managed to merge dequant with coefficient decoding instead.

> Dark Shikari
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bink-v2.patch
Type: text/x-diff
Size: 79777 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100217/f019893b/attachment.patch>