[FFmpeg-devel] [PATCH] MMX2/SSSE3 VC1 loop filter

[Ronald S. Bultje]

Hi,

On Jul 5, 2010, at 11:34 PM, David Conrad <lessen42 at gmail.com> wrote:
> On Jul 5, 2010, at 4:30 PM, Ronald S. Bultje wrote:
>>
>> On Mon, Jul 5, 2010 at 1:44 AM, David Conrad <lessen42 at gmail.com>  
>> wrote:
>>> Updated to patch cleanly, compile, and added mmx/sse2 versions
>> [..]
>>> +SECTION_RODATA
>>> +pw_4: times 8 dw 4
>>> +pw_5: times 8 dw 5
>>
>> cextern pw_4, pw_5 (i.e. use the ones in dsputil_mmx.c) maybe?
>
> This doesn't cause non-PIC problems on x86-64? I remember something  
> similar causing a problem in libvpx.

Only if using const+offset. It's fine when only deref'ing [const].

>>> +cglobal vc1_h_loop_filter8_sse4, 3,5,8
>>
>> Should this (and others like it) be under #ifdef X86_64? I got  
>> compile
>> errors if I tried to use xmm8-15 on x86_32.
>
> What compiler errors are you getting? This shouldn't use xmm8+ ever.

The ,8 at the end saves xmm8-15. Xmm0-7 are free to use. You can  
probably remove it unless I'm wrong (very well possible).

Ronald