[FFmpeg-devel] [PATCH] MMX2/SSSE3 VC1 loop filter

[Loren Merritt]

On Tue, 6 Jul 2010, Ronald S. Bultje wrote:
> On Jul 5, 2010, at 11:34 PM, David Conrad <lessen42 at gmail.com> wrote:
>> On Jul 5, 2010, at 4:30 PM, Ronald S. Bultje wrote:
>>
>>>> +cglobal vc1_h_loop_filter8_sse4, 3,5,8
>>> 
>>> Should this (and others like it) be under #ifdef X86_64? I got compile
>>> errors if I tried to use xmm8-15 on x86_32.
>> 
>> What compiler errors are you getting? This shouldn't use xmm8+ ever.
>
> The ,8 at the end saves xmm8-15. Xmm0-7 are free to use. You can probably 
> remove it unless I'm wrong (very well possible).

The ,8 says that it uses 8 xmmregs, namely xmm0-xmm7. Which does nothing 
at all on x86_32, since all xmms are caller-saved under x86_32 abi, but is 
needed for win64.

--Loren Merritt