[FFmpeg-devel] [PATCH] Explicit addl in snowdsp_mmx.c

[İsmail Dönmez]

On Mon, Oct 4, 2010 at 1:42 PM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Mon, Oct 04, 2010 at 08:18:56AM +0300, ?smail D?nmez wrote:
> > On Mon, Oct 4, 2010 at 12:23 AM, Michael Niedermayer <michaelni at gmx.at
> >wrote:
> >
> > > On Sun, Oct 03, 2010 at 11:55:23PM +0300, ?smail D?nmez wrote:
> > > > On Sun, Oct 3, 2010 at 11:54 PM, ?smail D?nmez <ismail at namtrac.org>
> > > wrote:
> > > > > On Sun, Oct 3, 2010 at 11:53 PM, Michael Niedermayer <
> michaelni at gmx.at>
> > > wrote:
> > > > >> On Sun, Oct 03, 2010 at 10:35:20PM +0300, ?smail D?nmez wrote:
> > > > >>> Hi;
> > > > >>>
> > > > >>> Another ambiguous asm. Use addl to use a specific width.
> > > > >>>
> > > > >>> OK?
> > > > >>
> > > > >> no the size is different on 64 and 32bit if iam not mistaken
> > > > >
> > > > > Oh, is there a way to make it work on both using another variant?
> > > >
> > > > I tested FATE on x86-64 btw.
> > >
> > > passing fate isnt helping, little endian is "forgiving" with such
> errors
> > > you need a bit of bad luck to see a failure
> > >
> >
> > What would be the correct solution?
>
> 2 lines in libavutil/x86_cpu.h
>

It should be addl for 64bit, but what about 32bit ? Also for define name
what do you suggest?

Thanks,
ismail