[FFmpeg-devel] [PATCH] Explicit addl in snowdsp_mmx.c

[Michael Niedermayer]

On Mon, Oct 04, 2010 at 01:50:30PM +0300, ?smail D?nmez wrote:
> On Mon, Oct 4, 2010 at 1:42 PM, Michael Niedermayer <michaelni at gmx.at>wrote:
> 
> > On Mon, Oct 04, 2010 at 08:18:56AM +0300, ?smail D?nmez wrote:
> > > On Mon, Oct 4, 2010 at 12:23 AM, Michael Niedermayer <michaelni at gmx.at
> > >wrote:
> > >
> > > > On Sun, Oct 03, 2010 at 11:55:23PM +0300, ?smail D?nmez wrote:
> > > > > On Sun, Oct 3, 2010 at 11:54 PM, ?smail D?nmez <ismail at namtrac.org>
> > > > wrote:
> > > > > > On Sun, Oct 3, 2010 at 11:53 PM, Michael Niedermayer <
> > michaelni at gmx.at>
> > > > wrote:
> > > > > >> On Sun, Oct 03, 2010 at 10:35:20PM +0300, ?smail D?nmez wrote:
> > > > > >>> Hi;
> > > > > >>>
> > > > > >>> Another ambiguous asm. Use addl to use a specific width.
> > > > > >>>
> > > > > >>> OK?
> > > > > >>
> > > > > >> no the size is different on 64 and 32bit if iam not mistaken
> > > > > >
> > > > > > Oh, is there a way to make it work on both using another variant?
> > > > >
> > > > > I tested FATE on x86-64 btw.
> > > >
> > > > passing fate isnt helping, little endian is "forgiving" with such
> > errors
> > > > you need a bit of bad luck to see a failure
> > > >
> > >
> > > What would be the correct solution?
> >
> > 2 lines in libavutil/x86_cpu.h
> >
> 
> It should be addl for 64bit, but what about 32bit ? Also for define name
> what do you suggest?

q on 64, l on 32

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101004/cc0543b4/attachment.pgp>