[FFmpeg-devel] [PATCH] ffplay: rename stream_pause() to stream_pause_resume()

Stefano Sabatini stefano.sabatini-lala at poste.it
Fri Apr 22 18:17:47 CEST 2011


On date Friday 2011-04-22 17:44:10 +0200, Alexander Strasser encoded:
> Hi
> 
> Stefano Sabatini wrote:
> > The new name is less misleading, since the function will resume the
> > stream if it is currently paused.
> > 
> > Signed-off-by: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > ---
> >  ffplay.c |   10 +++++-----
> >  1 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/ffplay.c b/ffplay.c
> > index c080cc0..1faa60e 100644
> > --- a/ffplay.c
> > +++ b/ffplay.c
> > @@ -1064,7 +1064,7 @@ static void stream_seek(VideoState *is, int64_t pos, int64_t rel, int seek_by_by
> >  }
> >  
> >  /* pause or resume the video */
> > -static void stream_pause(VideoState *is)
> > +static void stream_pause_resume(VideoState *is)
> >  {
> >      if (is->paused) {
> [remaining patch snipped]
> 
>   Maybe using the verb to toggle is more concise, e.g. just rename
> the function to "stream_toggle_pause".

Works for me, and it's even better.
-- 
FFmpeg = Fanciful and Fabulous Magic Plastic Ecumenical Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ffplay-rename-stream_pause-to-stream_toggle_pause.patch
Type: text/x-diff
Size: 1971 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110422/3ec3d48f/attachment.bin>


More information about the ffmpeg-devel mailing list