[FFmpeg-devel] [PATCH] ffplay: rename stream_pause() to stream_pause_resume()

[Michael Niedermayer]

On Fri, Apr 22, 2011 at 06:17:47PM +0200, Stefano Sabatini wrote:
> On date Friday 2011-04-22 17:44:10 +0200, Alexander Strasser encoded:
> > Hi
> > 
> > Stefano Sabatini wrote:
> > > The new name is less misleading, since the function will resume the
> > > stream if it is currently paused.
> > > 
> > > Signed-off-by: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > ---
> > >  ffplay.c |   10 +++++-----
> > >  1 files changed, 5 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/ffplay.c b/ffplay.c
> > > index c080cc0..1faa60e 100644
> > > --- a/ffplay.c
> > > +++ b/ffplay.c
> > > @@ -1064,7 +1064,7 @@ static void stream_seek(VideoState *is, int64_t pos, int64_t rel, int seek_by_by
> > >  }
> > >  
> > >  /* pause or resume the video */
> > > -static void stream_pause(VideoState *is)
> > > +static void stream_pause_resume(VideoState *is)
> > >  {
> > >      if (is->paused) {
> > [remaining patch snipped]
> > 
> >   Maybe using the verb to toggle is more concise, e.g. just rename
> > the function to "stream_toggle_pause".
> 
> Works for me, and it's even better.
> -- 
> FFmpeg = Fanciful and Fabulous Magic Plastic Ecumenical Gadget

>  ffplay.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> c4ac5aebf6a91fc2e5d0b04a37ae5bb3dd806ec5  0003-ffplay-rename-stream_pause-to-stream_toggle_pause.patch
> From 5f87c8be8becae83260d0413255e86d416aabf55 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Fri, 22 Apr 2011 02:19:48 +0200
> Subject: [PATCH] ffplay: rename stream_pause() to stream_toggle_pause()

LGTM

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110423/cedda954/attachment.asc>