[FFmpeg-devel] [PATCH] lavc/libtheoraenc: clarify comment about global_quality -> Theora quality conversion
Stefano Sabatini
stefasab at gmail.com
Tue Mar 19 18:15:27 CET 2013
---
libavcodec/libtheoraenc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
index 893370f..a2e5b74 100644
--- a/libavcodec/libtheoraenc.c
+++ b/libavcodec/libtheoraenc.c
@@ -207,11 +207,11 @@ static av_cold int encode_init(AVCodecContext* avc_context)
avcodec_get_chroma_sub_sample(avc_context->pix_fmt, &h->uv_hshift, &h->uv_vshift);
if (avc_context->flags & CODEC_FLAG_QSCALE) {
- /* to be constant with the libvorbis implementation, clip global_quality to 0 - 10
- Theora accepts a quality parameter p, which is:
- * 0 <= p <=63
- * an int value
- */
+ /* Clip global_quality in QP units to the [0 - 10] range
+ to be consistent with the libvorbis implementation.
+ Theora accepts a quality parameter which is an int value in
+ the [0 - 63] range.
+ */
t_info.quality = av_clipf(avc_context->global_quality / (float)FF_QP2LAMBDA, 0, 10) * 6.3;
t_info.target_bitrate = 0;
} else {
--
1.7.9.5
More information about the ffmpeg-devel
mailing list