[FFmpeg-devel] [PATCH] ffplay: remove -idct option

[Marton Balint]

On Tue, 19 Mar 2013, Stefano Sabatini wrote:

> The same option can be set as a codec option. No syntax change involved.
> ---
> ffplay.c |    3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ffplay.c b/ffplay.c
> index e7a24e0..c4cf5a5 100644
> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -294,7 +294,6 @@ static int64_t duration = AV_NOPTS_VALUE;
> static int fast = 0;
> static int genpts = 0;
> static int lowres = 0;
> -static int idct = FF_IDCT_AUTO;
> static int error_concealment = 3;
> static int decoder_reorder_pts = -1;
> static int autoexit;
> @@ -2470,7 +2469,6 @@ static int stream_component_open(VideoState *is, int stream_index)
>                 codec->max_lowres);
>         avctx->lowres= codec->max_lowres;
>     }
> -    avctx->idct_algo         = idct;
>     avctx->error_concealment = error_concealment;
>
>     if(avctx->lowres) avctx->flags |= CODEC_FLAG_EMU_EDGE;
> @@ -3368,7 +3366,6 @@ static const OptionDef options[] = {
>     { "genpts", OPT_BOOL | OPT_EXPERT, { &genpts }, "generate pts", "" },
>     { "drp", OPT_INT | HAS_ARG | OPT_EXPERT, { &decoder_reorder_pts }, "let decoder reorder pts 0=off 1=on -1=auto", ""},
>     { "lowres", OPT_INT | HAS_ARG | OPT_EXPERT, { &lowres }, "", "" },
> -    { "idct", OPT_INT | HAS_ARG | OPT_EXPERT, { &idct }, "set idct algo",  "algo" },
>     { "ec", OPT_INT | HAS_ARG | OPT_EXPERT, { &error_concealment }, "set error concealment options",  "bit_mask" },
>     { "sync", HAS_ARG | OPT_EXPERT, { .func_arg = opt_sync }, "set audio-video sync. type (type=audio/video/ext)", "type" },
>     { "autoexit", OPT_BOOL | OPT_EXPERT, { &autoexit }, "exit at the end", "" },

LGTM, thanks.

Marton