[FFmpeg-devel] [Bulk] [PATCH] lavfi: add smptehdbars source

[Kieran Kunhya]

On Tue, Apr 23, 2013 at 10:54 AM, Paul B Mahol <onemda at gmail.com> wrote:
> On 4/23/13, Tim Nicholson <nichot20 at yahoo.com> wrote:
>> On 11/04/13 23:44, Paul B Mahol wrote:
>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>> ---
>>>  doc/filters.texi           |   5 +-
>>>  libavfilter/Makefile       |   1 +
>>>  libavfilter/allfilters.c   |   1 +
>>>  libavfilter/vsrc_testsrc.c | 172
>>> ++++++++++++++++++++++++++++++++++++++-------
>>>  4 files changed, 151 insertions(+), 28 deletions(-)
>>>
>>> [..]
>>
>> Is there not a problem, in that ffmpeg always uses the 601 matrix for
>> conversion from rgb to YUV, and therefore if these bars are used at HD
>> frame sizes (which is what you would expect to do for HD bars), the
>> colours will then be wrong?
>>
>> Or have I missed something?
>
> I compared colors from one from wikipedia and it looks fine to me.

Just because colours match with wikipedia doesn't stop your
implementation being incorrect.