[FFmpeg-devel] [Bulk] [PATCH] lavfi: add smptehdbars source

[Paul B Mahol]

On 5/5/13, Kieran Kunhya <kierank at ob-encoder.com> wrote:
> On Tue, Apr 23, 2013 at 10:54 AM, Paul B Mahol <onemda at gmail.com> wrote:
>> On 4/23/13, Tim Nicholson <nichot20 at yahoo.com> wrote:
>>> On 11/04/13 23:44, Paul B Mahol wrote:
>>>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>>>> ---
>>>>  doc/filters.texi           |   5 +-
>>>>  libavfilter/Makefile       |   1 +
>>>>  libavfilter/allfilters.c   |   1 +
>>>>  libavfilter/vsrc_testsrc.c | 172
>>>> ++++++++++++++++++++++++++++++++++++++-------
>>>>  4 files changed, 151 insertions(+), 28 deletions(-)
>>>>
>>>> [..]
>>>
>>> Is there not a problem, in that ffmpeg always uses the 601 matrix for
>>> conversion from rgb to YUV, and therefore if these bars are used at HD
>>> frame sizes (which is what you would expect to do for HD bars), the
>>> colours will then be wrong?
>>>
>>> Or have I missed something?
>>
>> I compared colors from one from wikipedia and it looks fine to me.
>
> Just because colours match with wikipedia doesn't stop your
> implementation being incorrect.

I really do not see any bug report reported here, just some claims
without any proof.

Also recently swscale supports other matrix for conversion, even it is
case that drawutils, what is actually used in filter does not use
that.

In any case patch welcome.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>