[FFmpeg-devel] [PATCH 1/3] adpcm_dtk: Decode interleaved channels in parallel

[James Almer]

On 18/05/13 4:36 PM, Michael Niedermayer wrote:
> On Sat, May 18, 2013 at 02:16:58PM -0300, James Almer wrote:
>> On 18/05/13 1:42 PM, Michael Niedermayer wrote:
>>> On Sun, May 12, 2013 at 07:47:14PM -0300, James Almer wrote:
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>> ---
>>>>  libavcodec/adpcm.c | 55 +++++++++++++++++++++++++++---------------------------
>>>>  1 file changed, 27 insertions(+), 28 deletions(-)
>>>
>>> does this fix a bug, does it improve speed or what is the purpose
>>> of this patch (the commit message doesnt say and it should say)
>>
>> It should improve speed since it processes both channels in a single pass, 
>> instead of jumping back to the beginning of the frame after processing the
>> first channel.
> 
> If its intended to improve speed then you should include a mention
> of the actual achived speedup in the commit message as well.
> You need to benchmark anyway so you yourself know if your changes
> improve things ...

Guess i should have done it with more than just the time command...
Just did some actual benchmarks using AV_READ_TIME(); and it seems to be 
slower in most cases, so I'm dropping this patch.
Sorry for the noise.

Regards.