[FFmpeg-devel] [PATCH 1/3] adpcm_dtk: Decode interleaved channels in parallel

[Michael Niedermayer]

On Sat, May 18, 2013 at 07:18:39PM -0300, James Almer wrote:
> On 18/05/13 4:36 PM, Michael Niedermayer wrote:
> > On Sat, May 18, 2013 at 02:16:58PM -0300, James Almer wrote:
> >> On 18/05/13 1:42 PM, Michael Niedermayer wrote:
> >>> On Sun, May 12, 2013 at 07:47:14PM -0300, James Almer wrote:
> >>>> Signed-off-by: James Almer <jamrial at gmail.com>
> >>>> ---
> >>>>  libavcodec/adpcm.c | 55 +++++++++++++++++++++++++++---------------------------
> >>>>  1 file changed, 27 insertions(+), 28 deletions(-)
> >>>
> >>> does this fix a bug, does it improve speed or what is the purpose
> >>> of this patch (the commit message doesnt say and it should say)
> >>
> >> It should improve speed since it processes both channels in a single pass, 
> >> instead of jumping back to the beginning of the frame after processing the
> >> first channel.
> > 
> > If its intended to improve speed then you should include a mention
> > of the actual achived speedup in the commit message as well.
> > You need to benchmark anyway so you yourself know if your changes
> > improve things ...
> 
> Guess i should have done it with more than just the time command...
> Just did some actual benchmarks using AV_READ_TIME(); and it seems to be 
> slower in most cases, so I'm dropping this patch.

ok, in the future you might want to look at START/STOP_TIMER


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130519/2bef1911/attachment.asc>