[FFmpeg-devel] [PATCH] configure: Enable MinGW-w64's implementation of vsnprintf and pals

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat May 25 00:30:27 CEST 2013


On 24.05.2013, at 22:45, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> On 2013-05-24 3:37 AM, Reimar Döffinger wrote:
>> 
>> It just seems to me that special-casing newer mingw is additional effort that at best hides bugs in our code that still will affect some users.
> 
> What "bugs"? Using C99 is a bug now?

"Bug" is anything that makes the code not work as intended or desired (on a supported system one could add for clarity).
That does mean that using C99 can be a bug, yes.

> Also, it will only affect
> people using a certain range of MinGW-w64 SVN trunk. No actual
> release is affected. I don't consider this an issue.

I don't think everyone uses -w64 yet? What about MSVC? Or am I missing the point (I should probably have re-read the patch before answering).

>> And how easy will it be to find out which printf variant was used by the ffmpeg some user used in a bug report?
> 
> As easy as "please attach your config.log".

Wishful thinking I believe :-) You'd be lucky if they compiled themselves.

>> I admit I argued far longer than I care about it (and Windows in general), but my gut tells me it's a rather bad idea.
> 
> I wouldn't call it arguing, as much as healthy debate. :)

I didn't mean "argue" as a negative word, but I certainly wouldn't want to be at fault for dragging this out to a point where it wouldn't count as "healthy debate" anymore, that wouldn't be a good deal.


More information about the ffmpeg-devel mailing list