[FFmpeg-devel] [PATCH] configure: Enable MinGW-w64's implementation of vsnprintf and pals

Derek Buitenhuis derek.buitenhuis at gmail.com
Sat May 25 00:59:15 CEST 2013


On 2013-05-24 6:30 PM, Reimar Döffinger wrote:
>> What "bugs"? Using C99 is a bug now?
> 
> "Bug" is anything that makes the code not work as intended or desired (on a supported system one could add for clarity).
> That does mean that using C99 can be a bug, yes.

I think a macro would better handle it than not using %zu, but that is
out of the scope of this patch.

>> Also, it will only affect
>> people using a certain range of MinGW-w64 SVN trunk. No actual
>> release is affected. I don't consider this an issue.
> 
> I don't think everyone uses -w64 yet? What about MSVC? Or am I missing the point (I should probably have re-read the patch before answering).

This patch is only relevant to future MinGW-w64 releases, which
have a working vsnprintf, etc. implementation. Regular MinGW, MSVC,
and MinGW-w64 version 2 and earlier, will continue to work the same,
and correctly.

>> As easy as "please attach your config.log".
> 
> Wishful thinking I believe :-) You'd be lucky if they compiled themselves.

Perhaps we could add the MinGW runtime version to the "compiler
version" output under the 'ffmpeg -version' output? That would
in a lot more cases than this.

>> I wouldn't call it arguing, as much as healthy debate. :)
> 
> I didn't mean "argue" as a negative word, but I certainly wouldn't want to be at fault for dragging this out to a point where it wouldn't count as "healthy debate" anymore, that wouldn't be a good deal.

"Bikeshedding" ? ;)

- Derek


More information about the ffmpeg-devel mailing list