[FFmpeg-devel] [PATCH 3/3] lavfi: add haldclut filter.

[Clément Bœsch]

On Sun, May 26, 2013 at 10:28:34PM +0200, Stefano Sabatini wrote:
[...]
> > +static int config_output(AVFilterLink *outlink)
> > +{
> > +    AVFilterContext *ctx = outlink->src;
> > +
> > +    outlink->w = ctx->inputs[0]->w;
> > +    outlink->h = ctx->inputs[0]->h;
> > +    outlink->time_base = ctx->inputs[0]->time_base;
> > +    return 0;
> > +}
> 
> Is this even required?
> 

Yes, otherwise it triggers a assert IIRC. (you need to config_output if
you have multiple inputs).

[...]
> > +AVFILTER_DEFINE_CLASS(haldclut);
> > +
> > +static const AVFilterPad haldclut_inputs[] = {
> > +    {
> > +        .name         = "main",
> > +        .type         = AVMEDIA_TYPE_VIDEO,
> 
> > +        .get_video_buffer = ff_null_get_video_buffer, // XXX drop
> 
> What's the problem with removing it?
> 

It's a remaining note I left to myself when copy/pasting from vf select.
I didn't want to make too much changes at first, and just forgot to remove
it. Everything should be OK, I'll remove it and check before pushing.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130526/8bbd8aab/attachment.asc>