[FFmpeg-devel] [PATCH 08/11] ffserver: export recommented encoder configuration

[Reynaldo H. Verdejo Pinochet]

Hi

On 11/16/2014 10:46 PM, Lukasz Marek wrote:
> [..]
> @@ -3355,6 +3354,9 @@ static int add_av_stream(FFServerStream *feed, AVStream *st)
>      fst = add_av_stream1(feed, av, 0);
>      if (!fst)
>          return -1;
> +    if (av_stream_get_recommended_encoder_configuration(st))
> +        av_stream_set_recommended_encoder_configuration(fst,
> +            av_strdup(av_stream_get_recommended_encoder_configuration(st)));

Is the return of av_strdup here been freed somewhere?. Also
adding braces to ifs when the body is multilined wouldn't
hurt. Not a blocker of course.

Looks OK otherwise. Feel free to push after confirming ^

Bests,

-- 
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley