[FFmpeg-devel] [PATCH 08/11] ffserver: export recommented encoder configuration

[Lukasz Marek]

On 18.11.2014 22:50, Reynaldo H. Verdejo Pinochet wrote:
> Hi
>
> On 11/16/2014 10:46 PM, Lukasz Marek wrote:
>> [..]
>> @@ -3355,6 +3354,9 @@ static int add_av_stream(FFServerStream *feed, AVStream *st)
>>       fst = add_av_stream1(feed, av, 0);
>>       if (!fst)
>>           return -1;
>> +    if (av_stream_get_recommended_encoder_configuration(st))
>> +        av_stream_set_recommended_encoder_configuration(fst,
>> +            av_strdup(av_stream_get_recommended_encoder_configuration(st)));
>
> Is the return of av_strdup here been freed somewhere?. Also
> adding braces to ifs when the body is multilined wouldn't
> hurt. Not a blocker of course.

It is not freed here, but lets say setter takeover ownership of this 
pointer so it is freed in void of libavfromat if no one leak it in an abyss.