[FFmpeg-devel] [PATCH 3/4] avcodec: add unpack packed B-frames bitstream filter

[Andreas Cadhalpun]

On 05.04.2015 00:06, Michael Niedermayer wrote:
> On Fri, Apr 03, 2015 at 07:14:58PM +0200, Andreas Cadhalpun wrote:
>> Fixes Ticket #2913
>>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  Changelog                             |   1 +
>>  doc/bitstream_filters.texi            |  20 ++++
>>  libavcodec/Makefile                   |   1 +
>>  libavcodec/allcodecs.c                |   1 +
>>  libavcodec/mpeg4_unpack_bframes_bsf.c | 200 ++++++++++++++++++++++++++++++++++
>>  libavcodec/version.h                  |   2 +-
> 
>>  patcheck.tmp                          |   0
> 
> this shouldnt be in there

Oops, removed.

> [...]
>
> no need to use GetBitContext for working with bytes
> simple uint8_t should be faster
> or libavcodec/bytestream.h could be used

Yes, using the uint8_t buffer directly makes the code simpler and probably faster.
Additionally, I changed the check to 'buf_size <= MAX_NVOP_SIZE' for consistency.
New patch attached.

Best regards,
Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-add-unpack-packed-B-frames-bitstream-filter.patch
Type: text/x-diff
Size: 11273 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150405/7513b1a2/attachment.bin>