[FFmpeg-devel] [PATCH 3/4] avcodec: add unpack packed B-frames bitstream filter

[Michael Niedermayer]

On Sun, Apr 05, 2015 at 01:05:23AM +0200, Andreas Cadhalpun wrote:
> On 05.04.2015 00:06, Michael Niedermayer wrote:
> > On Fri, Apr 03, 2015 at 07:14:58PM +0200, Andreas Cadhalpun wrote:
> >> Fixes Ticket #2913
> >>
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> ---
> >>  Changelog                             |   1 +
> >>  doc/bitstream_filters.texi            |  20 ++++
> >>  libavcodec/Makefile                   |   1 +
> >>  libavcodec/allcodecs.c                |   1 +
> >>  libavcodec/mpeg4_unpack_bframes_bsf.c | 200 ++++++++++++++++++++++++++++++++++
> >>  libavcodec/version.h                  |   2 +-
> > 
> >>  patcheck.tmp                          |   0
> > 
> > this shouldnt be in there
> 
> Oops, removed.
> 
> > [...]
> >
> > no need to use GetBitContext for working with bytes
> > simple uint8_t should be faster
> > or libavcodec/bytestream.h could be used
> 
> Yes, using the uint8_t buffer directly makes the code simpler and probably faster.
> Additionally, I changed the check to 'buf_size <= MAX_NVOP_SIZE' for consistency.
> New patch attached.
> 
> Best regards,
> Andreas

>  Changelog                             |    1 
>  doc/bitstream_filters.texi            |   20 +++
>  libavcodec/Makefile                   |    1 
>  libavcodec/allcodecs.c                |    1 
>  libavcodec/mpeg4_unpack_bframes_bsf.c |  194 ++++++++++++++++++++++++++++++++++
>  libavcodec/version.h                  |    2 
>  6 files changed, 218 insertions(+), 1 deletion(-)
> 3b003a781b57adc97e9dbe88e6c259ecb3c0f347  0001-avcodec-add-unpack-packed-B-frames-bitstream-filter.patch
> From 17b471527705b5a9ec66f373fe69dc4a51d81379 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Fri, 3 Apr 2015 18:19:53 +0200
> Subject: [PATCH] avcodec: add unpack packed B-frames bitstream filter
> 
> Fixes Ticket #2913

applied

maybe you want to add a fate test ?
i can upload a small sample to the fate samples if you have one 

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150405/e4d3011b/attachment.asc>