[FFmpeg-devel] [PATCH] making qsv session routines private

[Sven Dueking]

> -----Ursprüngliche Nachricht-----
> Von: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] Im Auftrag
> von Sven Dueking
> Gesendet: Montag, 30. November 2015 11:06
> An: 'FFmpeg development discussions and patches'
> Betreff: Re: [FFmpeg-devel] [PATCH] making qsv session routines private
> 
> 
> 
> > -----Ursprüngliche Nachricht-----
> > Von: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] Im Auftrag
> > von Hendrik Leppkes
> > Gesendet: Montag, 30. November 2015 10:56
> > An: FFmpeg development discussions and patches
> > Betreff: Re: [FFmpeg-devel] [PATCH] making qsv session routines
> > private
> >
> > On Mon, Nov 30, 2015 at 10:45 AM, Sven Dueking <sven at nablet.com>
> wrote:
> > > Hi all,
> > >
> > > This is a follow up patch according to the discussion of
> > >
> > > [FFmpeg-devel] [PATCH] qsv.c: making qsv session routines
> > >
> > > Hopefully this is the correct way to share internal functions
> > > between codecs and filters.
> > > At least other filters seems to do it this way ...
> > >
> > > Thanks,
> > > Sven
> > >
> > >
> >
> > We really try to avoid avpriv in new code, as its a kludge at best.
> 
> Strange, this was suggested during the discussion
> 
> I guess we need a better way to share internal things. The currently
> nonsensical library separation makes this hard. We could just use
> avpriv_ in this case, or make a header-only implementation. Certainly
> it doesn't need to be public API.
> 
> So, do you prefer that I double the code or a header only
> implementation ?
> Or, is there another way to do this (besides avpriv) ?

Another option is to rename the header from QSV_internal.h to QSV_public.h (something like this) 
and use the av_ prefix. Not sure that it´s allowed, some other filters call av_ functions from the codecs.
What do you think ?

> 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel