[FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting
Michael Niedermayer
michael at niedermayer.cc
Sat Dec 3 14:43:02 EET 2016
On Sat, Dec 03, 2016 at 12:48:43PM +0100, Andreas Cadhalpun wrote:
> On 03.12.2016 00:52, Michael Niedermayer wrote:
> > It should still be possible to set these through recommended_encoder_configuration
> >
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> > libavformat/ffmdec.c | 27 ++++++++-------------------
> > 1 file changed, 8 insertions(+), 19 deletions(-)
> >
> > diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c
> > index 25edeebb7e..f3497e2b24 100644
> > --- a/libavformat/ffmdec.c
> > +++ b/libavformat/ffmdec.c
> > @@ -369,8 +369,8 @@ static int ffm2_read_header(AVFormatContext *s)
> > goto fail;
> > }
> > codec->flags = avio_rb32(pb);
> > - codec->flags2 = avio_rb32(pb);
> > - codec->debug = avio_rb32(pb);
> > + avio_rb32(pb);
> > + avio_rb32(pb);
>
> These (and the ones below) would also benefit from a code comment.
added locally
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161203/ba596d98/attachment.sig>
More information about the ffmpeg-devel
mailing list