[FFmpeg-devel] [PATCH 3/5] avformat/ffmdec: Drop flags2, debug and codec->time_base setting

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sat Dec 3 15:09:07 EET 2016


On 03.12.2016 13:43, Michael Niedermayer wrote:
> On Sat, Dec 03, 2016 at 12:48:43PM +0100, Andreas Cadhalpun wrote:
>> On 03.12.2016 00:52, Michael Niedermayer wrote:
>>> It should still be possible to set these through recommended_encoder_configuration
>>>
>>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>>> ---
>>>  libavformat/ffmdec.c | 27 ++++++++-------------------
>>>  1 file changed, 8 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c
>>> index 25edeebb7e..f3497e2b24 100644
>>> --- a/libavformat/ffmdec.c
>>> +++ b/libavformat/ffmdec.c
>>> @@ -369,8 +369,8 @@ static int ffm2_read_header(AVFormatContext *s)
>>>                  goto fail;
>>>              }
>>>              codec->flags = avio_rb32(pb);
>>> -            codec->flags2 = avio_rb32(pb);
>>> -            codec->debug = avio_rb32(pb);
>>> +            avio_rb32(pb);
>>> +            avio_rb32(pb);
>>
>> These (and the ones below) would also benefit from a code comment.
> 
> added locally

Thanks, patch is OK then.

Best regards,
Andreas


More information about the ffmpeg-devel mailing list